Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Options validation #406

Merged
merged 14 commits into from
Nov 26, 2021
Merged

Options validation #406

merged 14 commits into from
Nov 26, 2021

Conversation

tpasternak
Copy link
Contributor

No description provided.

@tpasternak tpasternak force-pushed the validation branch 3 times, most recently from 4940391 to da52a7d Compare November 19, 2021 14:31
@tpasternak tpasternak changed the title [DO NOT MERGE] Validation Options validation Nov 19, 2021
@tpasternak tpasternak marked this pull request as ready for review November 19, 2021 14:55
@lwronski lwronski mentioned this pull request Nov 22, 2021
Merged
@tpasternak
Copy link
Contributor Author

I think I covered the issues. The problem now is that the warnings may be reported twice, as prepareBuild method is called more than one time

@tpasternak
Copy link
Contributor Author

Apart from the information about duplicate positions of settings in Map[Platform, Positioned[Unit]] is lost, do you think it's a big issue?

@tpasternak tpasternak force-pushed the validation branch 3 times, most recently from e1f5342 to 2040c30 Compare November 25, 2021 16:10
alexarchambault
alexarchambault reviewed Nov 26, 2021
View reviewed changes
Copy link
Contributor

@alexarchambault alexarchambault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the NITs, LGTM!

modules/build/src/main/scala/scala/build/errors/BuildException.scala Outdated Show resolved Hide resolved
modules/build/src/main/scala/scala/build/errors/Severity.scala Outdated Show resolved Hide resolved
modules/build/src/main/scala/scala/build/errors/Severity.scala Outdated Show resolved Hide resolved
modules/build/src/main/scala/scala/build/options/validation/BuildOptionsRule.scala Outdated Show resolved Hide resolved
tpasternak and others added 13 commits November 26, 2021 17:04
@tpasternak
Validate conflicting options and track options sources
0f52b71
@tpasternak
Avoid duplicate plafrorms in extraPlatforms field
1ef3697 
Switch extraPlatforms from Set[Positioned[Platform] to Map[Platform, Positioned[Unit]]
@tpasternak
Allow warning-severity validation rules
c685286
@tpasternak @alexarchambault
Update modules/build/src/main/scala/scala/build/options/HashedField.s…
ae409ea 
…cala

Co-authored-by: Alexandre Archambault <alexarchambault@users.noreply.github.com>
@tpasternak @alexarchambault
Update modules/build/src/main/scala/scala/build/options/ScalaOptions.…
f3a7e8a 
…scala

Co-authored-by: Alexandre Archambault <alexarchambault@users.noreply.github.com>
@tpasternak @alexarchambault
Update modules/build/src/main/scala/scala/build/options/BuildOptions.…
638a01b 
…scala

Co-authored-by: Alexandre Archambault <alexarchambault@users.noreply.github.com>
@tpasternak
Test whether message is a warning
e7a66bb
@tpasternak
Fix config monoid for Map[K,V]
4d071d8
@tpasternak
Keep diagnostic info in a class that does not derive from Throwable
4013efa
@tpasternak @alexarchambault
Update modules/build/src/main/scala/scala/build/errors/Severity.scala
12681a5 
Co-authored-by: Alexandre Archambault <alexarchambault@users.noreply.github.com>
@tpasternak @alexarchambault
Update modules/build/src/main/scala/scala/build/errors/BuildException…
f538f29 
….scala

Co-authored-by: Alexandre Archambault <alexarchambault@users.noreply.github.com>
@tpasternak @alexarchambault
Update modules/build/src/main/scala/scala/build/errors/Severity.scala
5a9fd41 
Co-authored-by: Alexandre Archambault <alexarchambault@users.noreply.github.com>
@tpasternak @alexarchambault
Update modules/build/src/main/scala/scala/build/options/validation/Bu…
8f64f32 
…ildOptionsRule.scala

Co-authored-by: Alexandre Archambault <alexarchambault@users.noreply.github.com>
@tpasternak
Copy link
Contributor Author

I had to force-push because of conflicts

@tpasternak tpasternak merged commit 39af244 into VirtusLab:master Nov 26, 2021
@tpasternak tpasternak deleted the validation branch November 26, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexarchambault alexarchambault alexarchambault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tpasternak @alexarchambault