Fix running on JS release mode #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanowski
force-pushed
the
scalajs/release-mode
branch
from
d0d1c04
to
95ee650
Compare
romanowski
force-pushed
the
scalajs/release-mode
branch
2 times, most recently
from
dbcab5c
to
7683d85
Compare
romanowski
force-pushed
the
scalajs/release-mode
branch
from
7683d85
to
eb81f02
Compare
lwronski
reviewed
Jan 10, 2022
| @@ -365,7 +368,7 @@ trait CliLaunchers extends SbtModule { self => | |||
| } | |||
|
|
|||
| def nativeImage = | |||
| if (Properties.isLinux && arch == "x86_64") | |||
| if (Properties.isLinux && arch == "x86_64" && isCI) | |||
There was a problem hiding this comment.
Why we want to build linux-docker-image only in CI?
There was a problem hiding this comment.
This is oposite - we do not want to use docker on local development since it takes ages to build the project
lwronski
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #256