Fix Scala Native directory project caching #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanowski
approved these changes
Feb 9, 2022
|
Sure! I'll add some tests |
alexarchambault
approved these changes
Feb 14, 2022
| } | ||
| Iterator(elem.path.toString, content, "\n").map(bytes) | ||
| Iterator((elem.path.toString +: content :+ "\n"): _*).map(bytes) |
There was a problem hiding this comment.
We don't need to build a new string here, only to convert it to bytes from the iterator later on. This should have worked:
Suggested change
| Iterator((elem.path.toString +: content :+ "\n"): _*).map(bytes) | |
| (Iterator(elem.path.toString) ++ content.iterator ++ Iterator("\n")).map(bytes) |
romanowski
pushed a commit
to romanowski/scala-cli
that referenced
this pull request
Mar 10, 2022
* Fix Scala Native directory project caching * Adjust SN caching tests to test directory caching * run scalafmt * Add iterators instead of converting to string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if
scala-cli run srcDir --nativewas run, only the initial project would be cached and used, with following changes to the codebase being ignored.