Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "publish setup" command #926

Merged
merged 9 commits into from
Jul 27, 2022
Merged

Add "publish setup" command #926

merged 9 commits into from
Jul 27, 2022

Conversation

alexarchambault
Copy link
Contributor

@alexarchambault alexarchambault commented Apr 21, 2022 •
edited
Loading

Fixes #12.

@alexarchambault alexarchambault force-pushed the publish branch 4 times, most recently from a1150f9 to ae24f28 Compare May 4, 2022 18:58
@alexarchambault alexarchambault changed the title Slightly rework publish and add "publish setup" command Add missing publish features and add "publish setup" command May 4, 2022
@alexarchambault alexarchambault changed the title Add missing publish features and add "publish setup" command Add missing publish features and "publish setup" command May 4, 2022
@alexarchambault alexarchambault force-pushed the publish branch 5 times, most recently from 64684a3 to 33c8bc3 Compare May 5, 2022 12:23
@alexarchambault alexarchambault mentioned this pull request May 5, 2022
Closed
@alexarchambault alexarchambault marked this pull request as ready for review May 5, 2022 15:19
@alexarchambault alexarchambault force-pushed the publish branch 4 times, most recently from 89c7065 to 1d1c874 Compare May 9, 2022 09:16
This was referenced May 9, 2022
Merged
Merged
@alexarchambault alexarchambault mentioned this pull request May 10, 2022
Merged
@alexarchambault alexarchambault marked this pull request as ready for review July 7, 2022 10:38
Gedochao
Gedochao approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some NIT comments, none of which should block this PR;
LGTM, although I'd double check if everything works okay after the necessary rebase

modules/cli/src/main/scala/scala/cli/commands/publish/PublishSetup.scala Outdated Show resolved Hide resolved
modules/cli/src/main/scala/scala/cli/commands/util/SharedOptionsUtil.scala Show resolved Hide resolved
modules/integration/src/test/scala/scala/cli/integration/PublishSetupTests.scala Show resolved Hide resolved
@alexarchambault alexarchambault merged commit 31803c8 into VirtusLab:main Jul 27, 2022
@alexarchambault alexarchambault deleted the publish branch July 27, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gedochao Gedochao Gedochao approved these changes

@romanowski romanowski romanowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add publishing to Maven repositories capabilities
3 participants
@alexarchambault @romanowski @Gedochao