Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to publish to Maven Central in publish command #1003

Merged
merged 6 commits into from
May 11, 2022

Conversation

alexarchambault
Copy link
Contributor

Another batch of commits from #926.

@alexarchambault alexarchambault force-pushed the publish-maven-central branch 2 times, most recently from c693b5a to 4f39416 Compare May 10, 2022 16:01
@alexarchambault alexarchambault marked this pull request as ready for review May 10, 2022 17:42
Copy link
Contributor

@lwronski lwronski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we need some unit tests to avoid regression in the future.

@alexarchambault
Copy link
Contributor Author

IMO we need some unit tests to avoid regression in the future.

I wish too (unit or integration tests). But it seems we'd have to "mock" a Sonatype server instance, or use a docker-based one (which needs to be configured and all), and try make it look like the official Sonatype instances.

@alexarchambault alexarchambault merged commit 9b46e97 into VirtusLab:main May 11, 2022
@alexarchambault alexarchambault deleted the publish-maven-central branch May 11, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants