Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No-publish the root #178

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Conversation

armanbilge
Copy link
Contributor

Pretty sure this fixes #177. The (empty) root project was being published with the same name as the core module, causing it to overwrite with an empty jar.

@gauravkumar37
Copy link

Thanks for looking into this. Unfortunately, I still see empty jars.
I have checked out your PR, and ran sbt clean +package. The jars present in target/scala* directories are still 318 bytes only.

@armanbilge
Copy link
Contributor Author

I can't speak to your results. I ran publishLocal and it looks fine to me.

@armanbilge
Copy link
Contributor Author

@gauravkumar37 are you looking in target/scala* or core/jvm/target/scala? The former is supposed to be empty, the latter is not.

@gauravkumar37
Copy link

Yup, you're right. I was looking in the wrong place. This fixes the bug.

@armanbilge
Copy link
Contributor Author

armanbilge commented Oct 7, 2022

Right, the problem was that the empty root target/ was overwriting the core/jvm/target. No-publishing the root fixes that.

@gauravkumar37
Copy link

Thanks.

Off topic to this PR, I couldn't find any docs for scala 2.13 usage. The official guide is for scala 3 syntax.

@armanbilge
Copy link
Contributor Author

Scala 2.13 was a later addition in #162, this project was originally built targeting Scala 3. I am sure a docs PR would be welcome :)

@kpodsiad
Copy link
Contributor

kpodsiad commented Oct 7, 2022

Thank you @armanbilge for tackling this, I couldn't find time to look at this myself.

@kpodsiad kpodsiad merged commit fd5ce3b into VirtusLab:main Oct 7, 2022
UnconventionalMindset pushed a commit to UnconventionalMindset/scala-yaml that referenced this pull request Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jar for 0.0.5 version for scala 2.13 is empty
3 participants