Cross-build for Scala 2.13 #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
commented
Jul 7, 2022
| def scala3Version = "3.1.2" | ||
| def scala3Version = "3.2.0-RC2" |
There was a problem hiding this comment.
Had to bump to v3.2.0 since I was hitting some compiler bugs in 3.1.x.
Closed
|
Seems like this PR is on good way @armanbilge ;) |
kpodsiad
reviewed
Jul 12, 2022
| @@ -36,13 +37,11 @@ inThisBuild( | |||
|
|
|||
| ThisBuild / scalafixDependencies += "com.github.liancheng" %% "organize-imports" % "0.6.0" | |||
|
|
|||
| lazy val core = crossProject(JSPlatform, JVMPlatform, NativePlatform) | |||
| lazy val core = crossProject(JSPlatform, JVMPlatform /*, NativePlatform*/ ) | |||
There was a problem hiding this comment.
Is there a reason for commenting native version?
There was a problem hiding this comment.
Yes, because I had to bump to Scala 3.2.0-RC2 the Native plugin is not yet published for these versions.
There was a problem hiding this comment.
CI for for native can be disabled (for a while) to not block this PR
There was a problem hiding this comment.
@kpodsiad cool, thanks, I've fixed formatting and disabled Native CI for now.
There was a problem hiding this comment.
- for a while - as long as there is no ScalaNative plugin for 3.2.x ;)
kpodsiad
approved these changes
Jul 14, 2022
Merged
UnconventionalMindset
pushed a commit
to UnconventionalMindset/scala-yaml
that referenced
this pull request
Jan 18, 2023
* Cross-compile for 2.13 * Cross-compile integrations tests * Bump to 3.2.0-RC2 * Disable native plugin and temporarily remove native from CI (there is no one for 3.2.x)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #159.
I had a brief look at adding 2.12 as well, but that still requires more changes. 2.13 is pretty good for now :)