Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parses a nonexistent key as None #234

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Parses a nonexistent key as None #234

merged 2 commits into from
Jul 12, 2023

Conversation

andrelfpinto
Copy link
Contributor

@andrelfpinto andrelfpinto commented Jun 27, 2023 •
edited
Loading

Implicitly parses a nonexistent key as None in case of key type is Option[_]
Fix #203

@andrelfpinto
Parses a nonexistent key as None
0da1b6b 
Implicitly parses a nonexistent key as None in case of key type is Option[_]
@andrelfpinto andrelfpinto marked this pull request as ready for review June 27, 2023 19:27
lwronski
lwronski approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@lwronski lwronski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrelfpinto Thanks for your contribution. LGTM.

@lwronski lwronski merged commit 9054aff into VirtusLab:main Jul 12, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwronski lwronski lwronski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't require !!null for Option[T]
2 participants
@andrelfpinto @lwronski