-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make YamlError an Exception, makes for easier interop #300
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little bit left there, some tests to check positionality of errors. I'll
get to this.
…On Wed 29. May 2024 at 16:01, Tomasz Godzik ***@***.***> wrote:
***@***.**** approved this pull request.
Looks good, though it might conflict with #271
<#271>
@lbialy <https://github.com/lbialy> what do you think about merging the
other PR? Or is there still work needed and we can merge this one first?
—
Reply to this email directly, view it on GitHub
<#300 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACBVNUTZ5MTYAZ3777QCLPLZEXNSBAVCNFSM6AAAAABIO4C3SOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAOBVGUYTKOJVGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
So technically there may result conflicts with these two PRs. But in spirit they are not in conflict, right? They don't go against each other, if I understood it correctly. Nor do I have any problem with the aim of that other PR. But this PR is much simpler and can be merged and released right now, which would unblock me in a downstream project. Would it be possible to merge and release this toady, please @tgodzik @lbialy ? 🙏 |
Let me take a quick look.
…On Fri 31. May 2024 at 12:06, Ondra Pelech ***@***.***> wrote:
So technically there may result conflicts with these two PRs.
In spirit they are not in conflict, right? They don't go against each
other, if I understood it correctly. Nor do I have any problem with the aim
of that other PR.
But this PR is much simpler and can be merged and released right now,
which would unblock me in a downstream project. Would it be possible to
merge and release this toady, please @tgodzik <https://github.com/tgodzik>
@lbialy <https://github.com/lbialy> ? 🙏
—
Reply to this email directly, view it on GitHub
<#300 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACBVNUSCRJSNVSHEF6XYPKLZFBDRTAVCNFSM6AAAAABIO4C3SOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBRGY4DSNRWGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
yeah, it's fine |
@tgodzik will you handle the release or should I? do we do snapshots here? |
Versions 0.1.0 is running, but we do release snapshots. |
No description provided.