Make YamlError an Exception, makes for easier interop #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A little bit left there, some tests to check positionality of errors. I'll
get to this.
…On Wed 29. May 2024 at 16:01, Tomasz Godzik ***@***.***> wrote:
***@***.**** approved this pull request.
Looks good, though it might conflict with #271
<#271>
@lbialy <https://github.com/lbialy> what do you think about merging the
other PR? Or is there still work needed and we can merge this one first?
—
Reply to this email directly, view it on GitHub
<#300 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACBVNUTZ5MTYAZ3777QCLPLZEXNSBAVCNFSM6AAAAABIO4C3SOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAOBVGUYTKOJVGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
So technically there may result conflicts with these two PRs. But in spirit they are not in conflict, right? They don't go against each other, if I understood it correctly. Nor do I have any problem with the aim of that other PR. But this PR is much simpler and can be merged and released right now, which would unblock me in a downstream project. Would it be possible to merge and release this toady, please @tgodzik @lbialy ? 🙏 |
|
Let me take a quick look.
…On Fri 31. May 2024 at 12:06, Ondra Pelech ***@***.***> wrote:
So technically there may result conflicts with these two PRs.
In spirit they are not in conflict, right? They don't go against each
other, if I understood it correctly. Nor do I have any problem with the aim
of that other PR.
But this PR is much simpler and can be merged and released right now,
which would unblock me in a downstream project. Would it be possible to
merge and release this toady, please @tgodzik <https://github.com/tgodzik>
@lbialy <https://github.com/lbialy> ? 🙏
—
Reply to this email directly, view it on GitHub
<#300 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACBVNUSCRJSNVSHEF6XYPKLZFBDRTAVCNFSM6AAAAABIO4C3SOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBRGY4DSNRWGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
lbialy
approved these changes
May 31, 2024
|
yeah, it's fine |
|
@tgodzik will you handle the release or should I? do we do snapshots here? |
|
Versions 0.1.0 is running, but we do release snapshots. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.