Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate key in mapping - not allow to multine in simple key #93

Merged
merged 1 commit into from Nov 11, 2021

Conversation

lwronski
Copy link
Contributor

@lwronski lwronski commented Nov 9, 2021

No description provided.

Copy link
Contributor

@kpodsiad kpodsiad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks promising, but there are a few places that need more discussion.

@lwronski lwronski marked this pull request as ready for review November 11, 2021 09:56
Copy link
Contributor

@kpodsiad kpodsiad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome and CI is green. LGTM!

@lwronski lwronski merged commit 4eec7c4 into VirtusLab:main Nov 11, 2021
@kpodsiad kpodsiad added the bug Something isn't working label Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants