-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse TAG directives and node tag attribute #95
Conversation
yaml/shared/src/main/scala/org/virtuslab/yaml/internal/load/TagHandle.scala
Outdated
Show resolved
Hide resolved
yaml/shared/src/main/scala/org/virtuslab/yaml/internal/load/parse/Event.scala
Outdated
Show resolved
Hide resolved
yaml/shared/src/main/scala/org/virtuslab/yaml/internal/load/parse/Event.scala
Outdated
Show resolved
Hide resolved
case TokenKind.DocumentStart => | ||
productions.prependAll(ParseDocumentStart :: ParseDocumentStartOpt :: Nil) | ||
getNextEventImpl() | ||
case TokenKind.MappingStart | TokenKind.Scalar(_, _) | TokenKind.SequenceStart | | ||
TokenKind.FlowMappingStart | TokenKind.FlowSequenceStart | _: TokenKind.Anchor => | ||
TokenKind.FlowMappingStart | TokenKind.FlowSequenceStart | _: TokenKind.Anchor | | ||
_: TokenKind.Tag => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wdyt about introduce more descriptive type instead of writing TokenKind.FlowMappingStart TokenKind.FlowSequenceStart | _: TokenKind.Anchor | _: TokenKind.Tag
, but we can do it in another PR.
yaml/shared/src/test/scala/org/virtuslab/yaml/tokenizer/TagSuite.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.