Add tags to nodes #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwronski
approved these changes
Nov 13, 2021
yaml/shared/src/main/scala/org/virtuslab/yaml/YamlDecoder.scala
Outdated
Show resolved
Hide resolved
yaml/shared/src/test/scala/org/virtuslab/yaml/decoder/DecoderSuite.scala
Outdated
Show resolved
Hide resolved
yaml/shared/src/test/scala/org/virtuslab/yaml/decoder/DecoderSuite.scala
Outdated
Show resolved
Hide resolved
yaml/shared/src/test/scala/org/virtuslab/yaml/ConstructSuite.scala
Outdated
Show resolved
Hide resolved
yaml/shared/src/main/scala/org/virtuslab/yaml/internal/load/compose/Composer.scala
Show resolved
Hide resolved
yaml/shared/src/main/scala/org/virtuslab/yaml/YamlDecoder.scala
Outdated
Show resolved
Hide resolved
lwronski
approved these changes
Nov 13, 2021
yaml/shared/src/main/scala/org/virtuslab/yaml/YamlDecoder.scala
Outdated
Show resolved
Hide resolved
kpodsiad
force-pushed
the
add-tags-to-nodes
branch
from
96f741d
to
3126754
Compare
kpodsiad
force-pushed
the
add-tags-to-nodes
branch
from
3126754
to
d37b0f1
Compare
kpodsiad
force-pushed
the
add-tags-to-nodes
branch
from
d37b0f1
to
7fa721b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each YAML node except its kind (scalar, mapping, sequence) has also a tag. Tag property indicates the type that the application should use to represent a given node. Typically, most tags are not explicitly specified in the character stream so YAML processor has to resolve them on its own using some schema. Recommended done is core schema.
YamlDecodershould be easier to create. It'll be good to have some factory functions which will reduce required boilerplate (maybe as a follow-up PR?)