Removes Serializable interface #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docstring says "mixin" but it really isn't... It is only used by Module, and no Module subclass seems to implement it, either.
|
Should this be merged? |
|
Looking at the original commit 895fab7, it looks like the serialize operation also exists in basic_modules which should be removed. I think the use in parallelflow has already been changed. If serialize isn't used elsewhere, I am fine with the merge. |
|
This is used by parallelflow if the object to be returned to VisTrails is instance of Module. Now that |
remram44
added a commit
that referenced
this pull request
Jan 14, 2015
Removes Serializable interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docstring says "mixin" but it really isn't... It is only used by Module, and no Module subclass seems to implement it, either.
Subclasses of Module are marked as "missing implementation of abstract methods" because of it.