Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<FE310> Memory alignment of ROM is faulty! #212

Closed
akashkollipara opened this issue Jan 23, 2023 · 1 comment · Fixed by #213
Closed

<FE310> Memory alignment of ROM is faulty! #212

akashkollipara opened this issue Jan 23, 2023 · 1 comment · Fixed by #213
Assignees
@akashkollipara
Labels
bug-critical System failure can be predicted critical update This is a critical update cyancore framework Cyancore framework feature request terravisor Terravisor related issue

Comments

@akashkollipara
Copy link
Member

akashkollipara commented Jan 23, 2023 •
edited
Loading

Describe the bug
The RODATA region is incorrectly getting aligned due to bad alignment formulation in linker script.
. = ALIGN(4);

Expected behavior
RODATA needs to be aligned to next 4B boundary.

Fix:

  • Correct syntax is . = ALIGN(8);
@akashkollipara akashkollipara added critical update This is a critical update terravisor Terravisor related issue cyancore framework Cyancore framework feature request bug-critical System failure can be predicted labels Jan 23, 2023
@akashkollipara akashkollipara added this to the Boron milestone Jan 23, 2023
@akashkollipara akashkollipara self-assigned this Jan 23, 2023
akashkollipara added a commit that referenced this issue Jan 23, 2023
@akashkollipara
<FE310> Fixed memory alignment for RODATA
5525e92 
Issue: #212
@akashkollipara akashkollipara mentioned this issue Jan 23, 2023
Merged
@akashkollipara akashkollipara linked a pull request Jan 23, 2023 that will close this issue
<FE310> Fixed memory alignment for RODATA #213
Merged
akashkollipara added a commit that referenced this issue Jan 23, 2023
@akashkollipara
<FE310> Fixed memory alignment for RODATA
2254bc6 
Issue: #212
akashkollipara added a commit that referenced this issue Jan 24, 2023
@akashkollipara
Merge pull request #213 from VisorFolks/bugfix/akashkollipara/212-fe3…
c64b841 
…10-memalign

<FE310> Fixed memory alignment for RODATA

Issue: #212
@akashkollipara
Copy link
Member Author

Closing this issue.

pranjalchanda08 pushed a commit that referenced this issue Jan 31, 2023
@akashkollipara @pranjalchanda08
<FE310> Fixed memory alignment for RODATA
e87e068 
Issue: #212
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akashkollipara akashkollipara

Labels
bug-critical System failure can be predicted critical update This is a critical update cyancore framework Cyancore framework feature request terravisor Terravisor related issue
Projects
Terravisor
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

<FE310> Fixed memory alignment for RODATA VisorFolks/cyancore
1 participant
@akashkollipara