Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header logo image #137

Closed
bjarman opened this issue Feb 17, 2022 · 2 comments
Closed

Header logo image #137

bjarman opened this issue Feb 17, 2022 · 2 comments
Labels

Comments

@bjarman
Copy link

bjarman commented Feb 17, 2022

Hi!
I have a problem with the header logo image. In OJS default theme the header logo image is responsive. However when I switch to oldGregg theme the header logo image is not responsive but rather the actual image size all the time. Is this a known issue and is there a workaround?
Thanks/Fredrik

@Vitaliy-1 Vitaliy-1 added the bug label Feb 21, 2022
Vitaliy-1 added a commit that referenced this issue Feb 21, 2022
@Vitaliy-1
Copy link
Owner

Thanks, @bjarman!

The referenced commit should solve the issue. If you want to test, don't forget to clear the template cache after applying.
Feel free to let me know if the problem still persists after this commit

@bjarman
Copy link
Author

bjarman commented Mar 11, 2022

Hi again! The commit seems to have solved the issue some ways. However I am not sure the logo scales as it should. In another implementation using Bootstrap 4 the logo usually scales and alignes with the navbar. I am unfamiliar with the journal_branding heading that seems to be left adjacent to the navbar. In smaller viewports this makes the hamburger drop below the logo and the register and login links. Also, using a .svg image results in width 0 height 0 which makes the logo not visable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants