Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a page with the mailchimp embed for newsletter #152

Merged
merged 1 commit into from
Dec 2, 2019
Merged

Added a page with the mailchimp embed for newsletter #152

merged 1 commit into from
Dec 2, 2019

Conversation

simaob
Copy link
Contributor

@simaob simaob commented Dec 2, 2019 •
edited
Loading

All pertaining to TPI

newsletter can be found here: http://localhost:3000/tpi/newsletter

  • adds a new route for the newsletter under the home controller
  • adds a new view and some basic styles;
  • embeds the newsletter code from Mailchimp;
  • updates links to the newsletter to point to this page;
  • hides Subscribe to newsletter section under the newsletter action because it's redundant;

Not done here:

  • not the best styles;
  • didn't customize the mailchimp form for now.

aabdaab
aabdaab approved these changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@aabdaab aabdaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 👍

@aabdaab aabdaab merged commit 37a250d into develop Dec 2, 2019
@simaob simaob deleted the feature/embbed-newsletter branch December 6, 2019 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabdaab aabdaab aabdaab approved these changes

@rapzo rapzo Awaiting requested review from rapzo

@tsubik tsubik Awaiting requested review from tsubik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simaob @aabdaab