Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/cclow search filter #202

Merged
merged 26 commits into from
Dec 13, 2019
Merged

Feature/cclow search filter #202

merged 26 commits into from
Dec 13, 2019

Conversation

batraisk
Copy link

No description provided.

tsubik and others added 25 commits December 9, 2019 21:48
@tsubik
add controller and queries to perform full text search
3d2c6ff
@tsubik
WIP - adding search_counts route
c59d0d3
@tsubik
add geography full text search query
f65ca98
@tsubik
small refactor use inner LawsDropdownCategory component
cb7bf16
@tsubik
add targets full text query
7bf26e8
@tsubik
drop custom made full text search queries and use pg_search instead
c5b642a
@tsubik
add query objects
6e4d4cc
@tsubik
remove search_controller concern
f20d0d3
@tsubik
refactor legislation search
8094ec5
@tsubik
refactor cclow backend controllers to use query objects
19435b2
@tsubik
update recent scopes
e108661
add tags to Litigation cases page
bb60f23
add tags to Climate Targets and Legislation and policies page
cb5125d
@tsubik
add recent parameter to queries
02a2f93
@tsubik
lawsdropdown fix no-matches thing
c8e3d0f
@tsubik
smaller debounce
d86b415
@tsubik
change page title for search results pages
c86bf5f
@tsubik
add search title class
b2c30c7
@tsubik
fix breadcrumbs
6b97c13
@tsubik
Merge branch 'develop' into cclow/search-to-the-backend-pgsearch
2205130
add missing parts to pages
26197fb
add tags filter to litigations cases page
87faaae
add tags filter to climate targets and legislation pages
d7ffd42
Merge branch 'develop' into feature/cclow-searh-filter
4c81e60
Merge branch 'cclow/search-to-the-backend-pgsearch' into feature/cclo…
e070240 
…w-searh-filter
@simaob
Copy link
Contributor

simaob commented Dec 13, 2019

Are the filters hooked with the backend? They don't seem to be. Selecting a country doesn't filter the list of laws.

@tsubik
Copy link
Contributor

tsubik commented Dec 13, 2019

I think that's my bad, I saw a region before, missed the country. So, that's filtering by region only.

@tsubik
Copy link
Contributor

tsubik commented Dec 13, 2019

Taggin wasn't cleaned up before import, crap :/

image

@tsubik
Copy link
Contributor

tsubik commented Dec 13, 2019

or the delimiter should be ';' or maybe there were 2 delimiters :P

@simaob
Copy link
Contributor

simaob commented Dec 13, 2019

Yes there's some crap in there. But most of mine look good. I can sort it out in the prod console later =D split and save. =)

@tsubik
Copy link
Contributor

tsubik commented Dec 13, 2019

When filtering by Tags there should be AND not OR right?

@tsubik
Copy link
Contributor

tsubik commented Dec 13, 2019

or maybe OR

@simaob
Copy link
Contributor

simaob commented Dec 13, 2019

that's always a tough question... @faustoperez what do you think? Tags are "has this AND that" or "has this OR that"?

@tsubik
Copy link
Contributor

tsubik commented Dec 13, 2019

I see I must removed filter by geography.

@tsubik
Copy link
Contributor

tsubik commented Dec 13, 2019

Countries should be OR I guess, so maybe tags too for consitency.

@tsubik
Copy link
Contributor

tsubik commented Dec 13, 2019

I'm gonna bring back the geography filter @batraisk

@simaob
Copy link
Contributor

simaob commented Dec 13, 2019

Agreed, good thinking. OR it is.

@tsubik
Copy link
Contributor

tsubik commented Dec 13, 2019

Done, geography should work.

@simaob
Copy link
Contributor

simaob commented Dec 13, 2019

Any other feedback? It looks pretty good to me! =)

tsubik
tsubik approved these changes Dec 13, 2019
View reviewed changes
Copy link
Contributor

@tsubik tsubik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great for me too! Great work @batraisk

From my side, that optimization, and checking trigrams to search more like fuzzy match could be next step

@simaob
Copy link
Contributor

simaob commented Dec 13, 2019

Yes, sounds good! Can come in a separate PR!

@simaob simaob merged commit 1e2e26a into develop Dec 13, 2019
@simaob simaob deleted the feature/cclow-searh-filter branch December 13, 2019 12:22
@tsubik
Copy link
Contributor

tsubik commented Dec 13, 2019 •
edited
Loading

Let's check how it works on staging.

@batraisk
Copy link
Author

thank you @tsubik :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsubik tsubik tsubik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@batraisk @simaob @tsubik