-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing filters to litigations #228
Conversation
actually, gonna mark it as |
ready to review ☝️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looking good! =) Only comment is to sort the entities in the filters, so that they are alphabetical. Then it's good to ship
I added the sorting, gonna merge it now. |
@@ -74,11 +78,132 @@ def filter_by_to_status | |||
scope.joins(:events).where(events: {id: event_ids, event_type: params[:status]}).distinct | |||
end | |||
|
|||
# rubocop:disable Metrics/CyclomaticComplexity | |||
def filter_by_litigation_sides |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Crap we don't have any tests for queries? This seems complicated now :/
jurisdiction
,party_type
andside types
(types and names) from LitigationSide