Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/improving security #253

Merged
merged 3 commits into from
Jan 28, 2020
Merged

Chore/improving security #253

merged 3 commits into from
Jan 28, 2020

Conversation

tsubik
Copy link
Contributor

@tsubik tsubik commented Jan 27, 2020 •
edited
Loading

  • force_ssl for prod and staging, secure cookies, enable HSTS
  • add brakeman sast to search for suspicious code (we could probably use codeclimate also)
  • add bundle audit to search for vulnerabilities in used gems (we could depend on codeclimate or github, but this forces us to fix it as build is failing)

@tsubik tsubik requested review from aabdaab and simaob January 27, 2020 12:25
simaob
simaob approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@simaob simaob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers for this!

@simaob simaob merged commit 9f0c53c into develop Jan 28, 2020
@simaob simaob deleted the chore/improving-security branch January 28, 2020 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simaob simaob simaob approved these changes

@aabdaab aabdaab Awaiting requested review from aabdaab

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsubik @simaob