Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cait emissions data #255

Merged
merged 5 commits into from
Feb 4, 2020
Merged

Conversation

aabdaab
Copy link
Contributor

@aabdaab aabdaab commented Jan 28, 2020

No description provided.

@tsubik
Copy link
Contributor

tsubik commented Jan 28, 2020

We also need to enable dataset in the code. I think we might change the code to get all datasets we have in the directory. With the use of extra metadata property in yaml file like show or active we can always disable any of them. value_column could be also moved to yaml file. parse_value function, hmm, that one could stay or also be in yaml file as text that will be executed dynamically.

@simaob
Copy link
Contributor

simaob commented Jan 29, 2020

This is till WIP, right @edwardpmorris? until we get the data calculated in %?

@aabdaab
Copy link
Contributor Author

aabdaab commented Feb 4, 2020

this is ready ☝️ As Tomek suggested, we now get all the datasets from map_data folder and parse them if they have set active: true in the yaml metadata files.

Copy link
Contributor

@simaob simaob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! =) new data.

@simaob simaob merged commit 2053dea into develop Feb 4, 2020
@simaob simaob deleted the feature/add-cait-emissions-to-map branch February 4, 2020 14:04
@tsubik
Copy link
Contributor

tsubik commented Feb 4, 2020

Great 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants