Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: React component that handles EP.1.a.i and EP.1.a.ii metrics #457

Merged
merged 9 commits into from
Oct 12, 2023

Conversation

martintomas
Copy link
Collaborator

@martintomas martintomas added ruby Pull requests that update Ruby code javascript Pull requests that update Javascript code labels Oct 10, 2023
@martintomas martintomas self-assigned this Oct 10, 2023
Copy link
Contributor

@barbara-chaves barbara-chaves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just very small comments. The react components are perfect

app/assets/stylesheets/tpi/pages/ascor.scss Outdated Show resolved Hide resolved
app/javascript/components/tpi/AscorRecentEmissions.js Outdated Show resolved Hide resolved
app/javascript/components/tpi/AscorRecentEmissions.js Outdated Show resolved Hide resolved
martintomas and others added 4 commits October 12, 2023 10:02
Co-authored-by: Bárbara Chaves <barbarabarcellos90@gmail.com>
Co-authored-by: Bárbara Chaves <barbarabarcellos90@gmail.com>
Co-authored-by: Bárbara Chaves <barbarabarcellos90@gmail.com>
@martintomas martintomas merged commit e577ac2 into develop Oct 12, 2023
3 checks passed
@martintomas martintomas deleted the feat/ascor-assessment-filters branch October 24, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants