Deferrable mode for custom training job operators #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-galan
requested review from
molcay,
MaksYermak,
moiseenkov and
VladaZakharova
moiseenkov
reviewed
Mar 14, 2024
airflow/providers/google/cloud/operators/vertex_ai/custom_job.py
Outdated
Show resolved
Hide resolved
e-galan
force-pushed
the
add-defer-mode-to-custom-training-job-operators
branch
from
51e773f
to
4130d02
Compare
|
Why did you not add a system test for |
e-galan
force-pushed
the
add-defer-mode-to-custom-training-job-operators
branch
from
4130d02
to
be8d256
Compare
The system test is there now, thanks for pointing it out. |
e-galan
force-pushed
the
add-defer-mode-to-custom-training-job-operators
branch
2 times, most recently
from
3ff9b47
to
16a1f74
Compare
e-galan
force-pushed
the
add-defer-mode-to-custom-training-job-operators
branch
from
16a1f74
to
cdba3ae
Compare
moiseenkov
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds the deferrable mode feature for the following Vertex AI operators:
Other changes include:
VertexAIModelLink. The old link url did not work anymore, I replaced it with a working one.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.