Support for "soon" config option in --due=soon #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the documentation: "ttdl l --due=soon" show todos which are due in less than a few days, including overdue ones (the range is configurable and default value is 7 days). -> actually use the config value instead of hardcoding to seven days.
|
Thank you! It seems I missed this one.
If it works it is fine to move it. Anyway, by the end we get correctly parsed config. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for "soon" config option in --due=soon
From the documentation:
"ttdl l --due=soon" show todos which are due in less than a few days,
including overdue ones (the range is configurable and default value is 7 days).
-> actually use the config value instead of hardcoding to seven days.
I'm not 100% sure about moving parse_filter(), ideally the config file is parsed first and then all the cmdline options are applied. Let me know what you think or feel free to directly tweak the code to make things easier.