Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should Vocaluxe exclude skipped songs? #366

Closed
Michri opened this issue Jan 13, 2018 · 3 comments
Closed

Should Vocaluxe exclude skipped songs? #366

Michri opened this issue Jan 13, 2018 · 3 comments
Labels
feature request need feedback needs feedback from players, usually for bugs or problems

Comments

@Michri
Copy link

Michri commented Jan 13, 2018

We just played with last nightly build (29.12.2017). It was running really well (Thanks!), but

Playing any kind of party mode caused some surprised players. Within the same game (after a round) songs already skipped with jokers in rounds before were appearing again. That’s annoying. Can songs skipped via jokers be removed from pool - in same way as already played songs?

@Michri
Copy link
Author

Michri commented Feb 7, 2018

Am I the only one having this issue?

@lukeIam lukeIam added feature request need feedback needs feedback from players, usually for bugs or problems and removed need feedback needs feedback from players, usually for bugs or problems labels Feb 8, 2018
@lukeIam
Copy link
Member

lukeIam commented Feb 8, 2018

As explained in #368 (comment) the random function in party mode works with a random list of all songs that match the criteria.
Jokers just skip a song and take the next one from the list.
If the list runs empty it is refilled with all songs and shuffled again.
-> So you only having the chance to get a skipped song again if you've sung/sikpped all songs.

Do I understand stand you correct: you would like to ignore all joker skipped songs for the refill and sing already sung songs again? In my opinion a joker is a one time skip for the person that is currently using it. If the song will appear again (under the rare circumstances stated above) maybe two other persons like to sing it.

@lukeIam lukeIam added the need feedback needs feedback from players, usually for bugs or problems label Feb 8, 2018
@lukeIam lukeIam changed the title Random functionality to be improved Should Vocaluxe exclude skipped songs? Feb 8, 2018
@daggeg
Copy link
Contributor

daggeg commented Jan 30, 2020

I’m with lukelam on this. If it’s not easy to add this as an in-menu-option I think we should close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request need feedback needs feedback from players, usually for bugs or problems
Projects
None yet
Development

No branches or pull requests

4 participants