Performance pass #3 (Manual array copies)

Took 1 minute
VolmitSoftware · Sep 12, 2020 · 56ac439 · 56ac439
1 parent 9a7ab90
commit 56ac439
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 12 deletions.
diff --git a/src/main/java/com/volmit/react/controller/CommandController.java b/src/main/java/com/volmit/react/controller/CommandController.java
@@ -319,10 +319,7 @@ else if(c.getName().equalsIgnoreCase(Info.COMMAND_REACT))
 				{
 					String[] args = new String[a.length - 1];
 
-					for(int i = 1; i < a.length; i++)
-					{
-						args[i - 1] = a[i];
-					}
+					System.arraycopy(a, 1, args, 0, a.length - 1);
 
 					cmd.fire(plr ? px : s, args);
 				}

diff --git a/src/main/java/com/volmit/react/util/DoubleArrayUtils.java b/src/main/java/com/volmit/react/util/DoubleArrayUtils.java
@@ -4,10 +4,7 @@ public class DoubleArrayUtils
 {
 	public static void shiftRight(double[] values, double push)
 	{
-		for(int index = values.length - 2; index >= 0; index--)
-		{
-			values[index + 1] = values[index];
-		}
+		if (values.length - 2 + 1 >= 0) System.arraycopy(values, 0, values, 1, values.length - 2 + 1);
 
 		values[0] = push;
 	}

diff --git a/src/main/java/primal/compute/math/DoubleArrayUtils.java b/src/main/java/primal/compute/math/DoubleArrayUtils.java
@@ -5,10 +5,7 @@ public class DoubleArrayUtils
 {
 	public static void shiftRight(double[] values, double push)
 	{
-		for(int index = values.length - 2; index >= 0; index--)
-		{
-			values[index + 1] = values[index];
-		}
+		if (values.length - 2 + 1 >= 0) System.arraycopy(values, 0, values, 1, values.length - 2 + 1);
 
 		values[0] = push;
 	}