Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENG-12854: Unreasonable memory usage of the Go driver in sync mode #41

Merged
merged 7 commits into from Jul 24, 2017
Merged

ENG-12854: Unreasonable memory usage of the Go driver in sync mode #41

merged 7 commits into from Jul 24, 2017

Commits on Jul 19, 2017

  1. Record memory profile

    @gernest
    gernest committed Jul 19, 2017
    Configuration menu
    Copy the full SHA
    21863f8 View commit details
    Browse the repository at this point in the history

  2. avaoid heap allocation when reading

    @gernest
    gernest committed Jul 19, 2017
    Configuration menu
    Copy the full SHA
    edf7bb8 View commit details
    Browse the repository at this point in the history

  3. avoid heap allocations

    @gernest
    gernest committed Jul 19, 2017
    Configuration menu
    Copy the full SHA
    e7bc78e View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2017

  1. Cleanup 

    Remove duplicate constants
    @gernest
    gernest committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    9b63c39 View commit details
    Browse the repository at this point in the history

  2. add test-race rule 

    This runs tests with -race enabled . Useful for catching race conditions
    @gernest
    gernest committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    445f515 View commit details
    Browse the repository at this point in the history

  3. Delete unused code

    @gernest
    gernest committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    b7cf02b View commit details
    Browse the repository at this point in the history

  4. Use a single decoder and encoder instance 

    *nodeConn is not used concurrently. This enables us to reuse the same e Enoder/Decoder instance.

There is no need to having a pool of encoders since the number of encoders is approximately diretly proportional to the number of connections.
    @gernest
    gernest committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    f966be0 View commit details
    Browse the repository at this point in the history