Adding getter for RawImage and disabling user controls. #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows to disable controls on the WebBrowser instance.
Voltstro
requested changes
Jul 20, 2022
src/Packages/UnityWebBrowser/Runtime/Core/RawImageUwbClientInputHandler.cs
Outdated
Show resolved
Hide resolved
src/Packages/UnityWebBrowser/Runtime/Core/RawImageUwbClientInputHandler.cs
Outdated
Show resolved
Hide resolved
src/Packages/UnityWebBrowser/Runtime/Core/RawImageUwbClientInputHandler.cs
Outdated
Show resolved
Hide resolved
src/Packages/UnityWebBrowser/Runtime/Core/RawImageUwbClientInputHandler.cs
Outdated
Show resolved
Hide resolved
src/Packages/UnityWebBrowser/Runtime/Core/RawImageUwbClientInputHandler.cs
Outdated
Show resolved
Hide resolved
src/Packages/UnityWebBrowser/Runtime/Core/RawImageUwbClientInputHandler.cs
Outdated
Show resolved
Hide resolved
src/Packages/UnityWebBrowser/Runtime/Core/RawImageUwbClientManager.cs
Outdated
Show resolved
Hide resolved
|
Perfect thanks for the reply, I'll clean that up. |
|
@Voltstro should be good to review. |
Voltstro
requested changes
Jul 21, 2022
| float scroll = inputHandler.GetScroll(); | ||
| scroll *= browserClient.BrowserTexture.height; | ||
|
|
||
| if (!disableMouseInputs && scroll != 0) |
There was a problem hiding this comment.
Don't need this extra !disableMouseInputs check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So here some small edits used for my project, I though I'd share it as this could be useful for someone else too.
I needed to:
Let me know if you see possible improvements to this.