Fix from is now mandatory for WA verify2 (WABA) (#469)

Vonage · Feb 19, 2024 · db8d8b9 · db8d8b9
1 parent ba6b02a
commit db8d8b9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/Verify2/Request/WhatsAppRequest.php b/src/Verify2/Request/WhatsAppRequest.php
@@ -10,14 +10,14 @@ class WhatsAppRequest extends BaseVerifyRequest
     public function __construct(
         protected string $to,
         protected string $brand,
-        protected ?string $from = null,
+        protected string $from,
         protected ?VerificationLocale $locale = null,
     ) {
         if (!$this->locale) {
             $this->locale = new VerificationLocale();
         }
 
-        $workflow = new VerificationWorkflow(VerificationWorkflow::WORKFLOW_WHATSAPP, $to);
+        $workflow = new VerificationWorkflow(VerificationWorkflow::WORKFLOW_WHATSAPP, $to, $from);
 
         $this->addWorkflow($workflow);
     }

diff --git a/test/Verify2/ClientTest.php b/test/Verify2/ClientTest.php
@@ -255,11 +255,12 @@ public function testCanRequestWhatsApp(): void
     {
         $payload = [
             'to' => '07785254785',
+            'from' => '07785254785',
             'client_ref' => 'my-verification',
             'brand' => 'my-brand',
         ];
 
-        $whatsAppVerification = new WhatsAppRequest($payload['to'], $payload['brand']);
+        $whatsAppVerification = new WhatsAppRequest($payload['to'], $payload['brand'], $payload['from']);
         $whatsAppVerification->setClientRef($payload['client_ref']);
 
         $this->vonageClient->send(Argument::that(function (Request $request) use ($payload) {
@@ -269,6 +270,7 @@ public function testCanRequestWhatsApp(): void
             $this->assertRequestJsonBodyContains('code_length', 4, $request);
             $this->assertRequestJsonBodyContains('brand', $payload['brand'], $request);
             $this->assertRequestJsonBodyContains('to', $payload['to'], $request, true);
+            $this->assertRequestJsonBodyContains('from', $payload['from'], $request, true);
             $this->assertRequestJsonBodyContains('channel', 'whatsapp', $request, true);
             $this->assertEquals('POST', $request->getMethod());