Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix from is now mandatory for WA verify2 (WABA) #469

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

SecondeJK
Copy link
Contributor

@SecondeJK SecondeJK commented Feb 19, 2024

from parameter is now mandatory when using WhatsApp for Verify v2

Description

Previously, a shared Vonage WABA was used. This is no longer the case.

Motivation and Context

I am counting this as a patch, but it is technically a change that is backwards breaking. This is, however, at the API level and therefore it is the API versioning that should be adjusted. A major release at this point is likely to cause more difficulties to customers than a patch to make sure the SDK has parity with the API.

How Has This Been Tested?

Tests adjusted

Example Output or Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@SecondeJK SecondeJK merged commit db8d8b9 into main Feb 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant