Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify v2 Validation Updates #309

Merged
merged 7 commits into from
Jun 19, 2024
Merged

Verify v2 Validation Updates #309

merged 7 commits into from
Jun 19, 2024

Conversation

superchilled
Copy link
Contributor

@superchilled superchilled commented Apr 23, 2024

This PR adds some validtion checks to the Verify v2 implementation. Specifically it:

  • Adds a check to the SMS class from setter to ensure that:
    • Numeric values are between 11 and 15 characters in length
    • Alphanumeric values are between 3 and 11 characters in length
  • Adds a check to the WhatsApp class from setter to ensure that values are between 11 and 15 characters in length
  • Adds a check in the Verify2#start_verification method to ensure that the brand argument is between 1 and 16 characters in length

@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.31%. Comparing base (35e4214) to head (17cb17b).

❗ Current head 17cb17b differs from pull request most recent head 22f9655. Consider uploading reports for the commit 22f9655 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #309      +/-   ##
==========================================
+ Coverage   98.19%   98.31%   +0.11%     
==========================================
  Files         132      132              
  Lines        2333     2313      -20     
==========================================
- Hits         2291     2274      -17     
+ Misses         42       39       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superchilled superchilled marked this pull request as ready for review April 23, 2024 14:12
@superchilled superchilled merged commit 2c04bc4 into main Jun 19, 2024
14 checks passed
@superchilled superchilled deleted the verify2-validation-updates branch June 19, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants