Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix trackpoint #11

Merged
merged 7 commits into from
Jun 23, 2020
Merged

Fix trackpoint #11

merged 7 commits into from
Jun 23, 2020

Conversation

gimdh
Copy link
Contributor

@gimdh gimdh commented Jun 22, 2020

Fixed overflow issue and typo (dx -> dy)

@gimdh gimdh mentioned this pull request Jun 22, 2020
Closed
1Revenger1
1Revenger1 requested changes Jun 22, 2020
View reviewed changes
VoodooRMI/Functions/F03.cpp Outdated Show resolved Hide resolved
VoodooRMI/Utility/ButtonDevice.cpp Outdated Show resolved Hide resolved
1Revenger1
1Revenger1 requested changes Jun 23, 2020
View reviewed changes
Copy link
Collaborator

@1Revenger1 1Revenger1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, do you mind setting the default under Info.plist for deadzone to 1? It's a lot less jumpy on my device at least.

VoodooRMI/Functions/F03.cpp Outdated Show resolved Hide resolved
@1Revenger1
Copy link
Collaborator

Looks good to me, unless there are some other things you want fixed/changed before this is merged in

@gimdh
Copy link
Contributor Author

gimdh commented Jun 23, 2020

I am okay with this.

@gimdh gimdh closed this Jun 23, 2020
@gimdh gimdh reopened this Jun 23, 2020
@1Revenger1 1Revenger1 merged commit b760024 into VoodooSMBus:master Jun 23, 2020
@VinylNerd VinylNerd mentioned this pull request Dec 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1Revenger1 1Revenger1 1Revenger1 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gimdh @1Revenger1