Exception safety clarification #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dureuill I'd appreciate it if you could review the code and text change. |
Voultapher
force-pushed
the
exception-safety-clarification
branch
from
1a058f4
to
e93776d
Compare
Changing FFIStringCpp to something that is not considered a POD type by the type system revealed a subtle, but previously effectless issue. The custom _by comparison constructs treated the types as the original FFI types and not as the derived C++ types. This did not have any effect because all derived types had the same POD semantics, and the comparison function was provided by the Rust side. But with FFIStringCpp changing to a non-trivially copyable move only type, this issue was revealed. The fix is to provide the comparison constructs with the derived type and to take a comparison function-pointer as generic template parameter to decouple T and the parameter type of the function-pointer. In addition the Rust side now understands FFIString in a moved from state and can safely destroy such values.
Voultapher
force-pushed
the
exception-safety-clarification
branch
from
e93776d
to
c0e1f81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16 see commit messages for detailed explanations.