Rajan/preamble fb #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rajan-chari
commented
Nov 26, 2018
rajan-chari
commented
- Flatbuffer
- Object pooling and memory management for FB
- Preamble changes
- Manually merged master
…inforcement_learning into rajan/preamble_fb
…inforcement_learning into rajan/preamble_fb
ataymano
reviewed
Nov 27, 2018
ataymano
reviewed
Nov 27, 2018
jackgerrits
approved these changes
Nov 27, 2018
tyclintw
reviewed
Nov 28, 2018
tyclintw
reviewed
Nov 28, 2018
tyclintw
reviewed
Nov 28, 2018
tyclintw
reviewed
Nov 28, 2018
tyclintw
reviewed
Nov 28, 2018
tyclintw
reviewed
Nov 28, 2018
tyclintw
reviewed
Nov 28, 2018
tyclintw
reviewed
Nov 28, 2018
jackgerrits
reviewed
Nov 29, 2018
…_sender and i_message_sender 2) linux_build
ataymano
reviewed
Dec 3, 2018
| using offset_vector_t = typename std::vector<flatbuffers::Offset<fb_event_t>>; | ||
| using batch_builder_t = RankingEventBatchBuilder; | ||
|
|
||
| static size_t size_estimate(const ranking_event& evt) { |
There was a problem hiding this comment.
This size estimation is required for controlling size of queue in memory (before serialization), and there is nothing fb-specific in implementation as well. So, probably it should not be part of serializer? We have static assert that any event have to be inherited from base event class, so probably it is cleaner to add size() method to that interface? In this case we also can get rid of size argument for event_queue::push.
ataymano
approved these changes
Dec 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.