Update vw submodule #433
Merged
Update vw submodule #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackgerrits
approved these changes
Oct 6, 2021
slahabar
approved these changes
Oct 6, 2021
|
binary parser is failing semi-spuriously so taking a look at that |
zwd-ms
added a commit
that referenced
this pull request
Oct 28, 2021
* [Binary parser] reward functions for ccb format (#361) * [Binary parser] refactoring rewards (#366) * Example gen add ccb loop for e2e testing (#368) * [Binary parser] add e2e ccb test, compare dsjson and fb logged files create the same model (#369) * minor binary parser cleanup (#370) * [Binary parser] add external parser test for apprentice mode cb (#374) * CCB apprentice reward (#373) * [Binary parser] add metrics for cb (#371) * [Binary parser] don't log when skip learn, more tests, skip over unknown msg type (#375) * [binary parser] ccb skip learn (#376) * refactor: add error message to fix config file (#377) * Fix CI's after flatbuffer version update to 2.0 (#390) * try set fb span minimal * add to preprocessor definitions * add to unit_test project file * Revert "mac ci: continue on error true (#327)" (#385) * Fix python build path on windows, and formatting. (#383) * Update build_docs.yml (#391) * only convert timestamp to string before exiting (#382) * ntohl is a define on osx, rename the function. (#386) * Add bunch of nice to haves CLI options and fix FB 2.0 compat. (#387) * our build requires CMP0074 due to usage of PackageName_ROOT variables. (#393) * our build requires CMP0074 due to usage of PackageName_ROOT variables. * try to use cmake_policy * Activations in multistep: first PR with schema changes only (#392) * deferred action to multistep schema * Multistep to problem type * try to set cmake policy for CMP0074 * OLD -> NEW * try default policy for cmp0074 * example_gen enhancements (#380) * [Binary parser] tests for CCB apprentice and skip learn (#379) * Switch to SAX parsing get the perf we need. (#388) * fix cli override to work with converter. * Switch from DOM to SAX and make it significantly faster. On my machine, using our standard gen path: With DOM: 76Mbps. With SAX: 103Mbps. * use RawValue instead of doing a SAX read/write. * disable example parsing. * cleanp and std::replace eol with space. * update * Fix disable example parsing for converted. * Add pdrop field for cb log converter (#396) * pdrop fix in binary parser (#351) * pdrop fix in binary parser * int -> float * main function for log_gen * verbose mode for parser * log gen fixes/enhancements * test generation notebook * simplified test data * cleanup * pdrop==0.5 test * test_gen + results update * explicit skip of examples with pdrop out of [0, 1) * pdrop==1 test * regenerated test sets (with pdrop == 0) * rcrfrmr -> rcrrmr * pdrop tests temporary removal * build fix * unit tests restore * wrong change revert * readme update * ipynb -> py * verbose print fix * wrong pdrop fix * log error for pdrop==1 * feat: Add binary parser for cats (#394) * feat: Add binary parser for cats * move interaction_data struct out of VW * commented changes and added learning_mode to cats * formatting * add reward calc tests * formatting * joined_event function update * check example length * finn_in_label bool Co-authored-by: olgavrou <olgavrou@gmail.com> * ccb log converter (#381) * Multistep joiner test + activations for multistep (#398) * pdrop fix in binary parser * int -> float * main function for log_gen * verbose mode for parser * log gen fixes/enhancements * test generation notebook * simplified test data * cleanup * pdrop==0.5 test * test_gen + results update * explicit skip of examples with pdrop out of [0, 1) * pdrop==1 test * regenerated test sets (with pdrop == 0) * rcrfrmr -> rcrrmr * pdrop tests temporary removal * build fix * unit tests restore * wrong change revert * readme update * ipynb -> py * verbose print fix * wrong pdrop fix * test_gen cleanup * log_gen: multistep event * log_gen: multistep_event / outcome * multistep log_gen fixes * multistep joiner test data gen * multistep log_gen: previous_id * log_gen; reward sign fix * test_gen: indices fix * multistep_2_episodes test * multistep deferred episodes test data * multistep activations failing test * log error for pdrop==1 * get rid of mk_cb_outcome * multistep activations test fix * ipython directives cleanup * feat: Add skip_learn and metrics tests for cats binary parser (#399) * feat: Add skip_learn tests for cats binary parser * add metrics tests * Update test_metrics.cc * feat: cats log converter (#400) * feat: cats log converter * skip_learn and formatting * Update flatbuffers version in readme (#401) * [Binary parser] set weight on all examples (#402) * Log gen cleanup (#406) * log_gen cleanup * deterministic client time generation * deterministic timestamp generation 2 * spacing cleanup * [Binary parser] enable client time utc (#403) * [Binary parser] Enable binary parser to handle slates payload (#404) * Slates parsing and reward calculation * Combine fill_in_label and set_cost * refactor skip learn + default reward * Slates log converter * set policy if exists in cmake version available (#410) * set policy if exists in cmake version available * add if policy to external_parser * Topological sort within episode (#408) * log_gen cleanup * deterministic client time generation * deterministic timestamp generation 2 * spacing cleanup * unordered episode testgn + test file * unordered episode joiner test (failing) * test_gen timestamps fix * unordered episode test fix * legacy comment cleanup * reference fix * comment * Slates e2e tests (#411) * feat: adding the original label cost to the binary parsers metrics (#412) * adding the original label cost to the binary parsers metrics * Update external_parser/joiners/example_joiner.cc Fix summation bug Co-authored-by: olgavrou <olgavrou@gmail.com> * no summation for skip learn events. Fix tests Co-authored-by: olgavrou <olgavrou@gmail.com> * feat: add ca end-to-end tests (#409) * feat: add ca-loop to example_gen * add test for ca-loop * formatting * e2e tests * formatting * fix test * test VW model for dsjson vs binary * formatting * commented changes * fix bug * revert activation_ratio arg Co-authored-by: cheng-tan <chengtan2013@gmail.com> Co-authored-by: olgavrou <olgavrou@gmail.com> * ci: dont update homebrew in MacOS CI (#418) * ci: upgrade Ubuntu16.04 workflows to Ubuntu 18.04 (#417) * log_parser 2 pandas (+ usage example) (#425) * Add apim authorization (#414) * initial commit * transportclient * fix spaces * fix spaces * add file references to project * fix pipeline build failures * unit test build failure * unit test cmake failures * fixes api key + add some comments * fix compile flag for build failure * rename function get to something more meaningful refactor apim create sender code * fix references in filter proj * causing mac os ci build failure * addresses comments * fix build error * restore.sh * build, transport, cmake * fix build error windows * revert http_auth * http_auth to event hub rename * eventhub changes back in * addresses comments * minor space clean up * fix more spaces * extra spaces * adds internal_constants.h and check for apikey * Move http_transport_client template implementation code to .h file + rename internal constants namespace (#427) * initial commit move template implementation code to .h file, rename internal constants variable * rename internal constants * trigger build * add internal_constants.h to cmake (#428) * add internal_constants.h to cmake * Trigger Build * Multistep rewards (#426) * suffix reward v0 * multistep reward parameter * multistep reward functions implementation * unit tests fix * multistep rewards unit tests * cleanup + comment * minor cleanups * tests cleanup * get rid of dynamic_cast * vector<pair> -> map * windows build fix * win build fix 2 * build fix * doc: update readme docs to make building clearer especially with regards to cmake (#432) * doc: update readme docs to make building clearer especially with regards to cmake * remove targets from readme * Update vw submodule (#433) * feat: Adds new metric DsjsonSumOriginalCostFirstSlot that aggregrates… (#429) * fix: emit dsjson_sum_cost_original metric (#434) * feat: Enable subsampling of events via configuration (#430) * Enable subsampling of events via configuration * use function to check is_equal * Update unit_test/async_batcher_test.cc Co-authored-by: Jack Gerrits <jackgerrits@users.noreply.github.com> * PR comments * constantize a magic number * remove unnecessary comment * address PR comments Co-authored-by: Jack Gerrits <jackgerrits@users.noreply.github.com> Co-authored-by: olgavrou <olgavrou@gmail.com> * feat: add new metric dsjson_sum_cost_original_baseline (#435) * Fix cmake for conditional python include (#436) * Benchmarks and github action to run them in CI (#405) * Fix sending to episode eventhub after merging. * Fix merge and build warnings. Co-authored-by: cheng-tan <chengtan2013@gmail.com> Co-authored-by: olgavrou <olgavrou@gmail.com> Co-authored-by: Griffin Bassman <griffinbassman@gmail.com> Co-authored-by: Eduardo Salinas <edus@microsoft.com> Co-authored-by: Rodrigo Kumpera <kumpera@users.noreply.github.com> Co-authored-by: Alexey Taymanov <41013086+ataymano@users.noreply.github.com> Co-authored-by: peterychang <49209570+peterychang@users.noreply.github.com> Co-authored-by: Jack Gerrits <jackgerrits@users.noreply.github.com> Co-authored-by: Sheetal Lahabar <lamadh@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: don't use enabled_reductions in json parser for ccb metrics #3377
feat: AutoML interactions #3252
refactor: remove unused classes from other approaches to extent based interactions #3376
feat: Adds new ccb metrics for comparing first slot label with the us… #3365
feat: Adds new metric for aggregating original label cost for first slot #3359
refactor: Migrate chisq save_load to process_model_field #3358
refactor: Add label and use builder to set learner features in ect, log_multi, recall_tree, warm_cb #3357
refactor: change counters to better reflect usage of pool #3342
fix: fix bug where read_lines would ignore given length #3343
test: fix for using -o outside of test dir #3355
test: allow tests requiring spanning tree to be skipped #3353
feat: support extent based interaction #3348
test: Use proper substitution names to support run_tests.py #3354
fix: Fix CCB slot aggregation for original label cost metric #3350
ci: reuse a single file instead of adding files on each iteration for input format benchmarks #3349
perf: create benchmark for sum_ft_squared #3345
ci: cancel previous runs in same PR #3347
ci: run benchmark job on self hosted runner #3344
refactor: Add label and use builder to set learner features in kernel_svm, lda_core, lrq, lrqfa, memory_tree #3341
fix: active was using inf values for sensitivity #3321
refactor: Apply clang-tidy performance fixes #3338
refactor: migrate from typedef to using #3339
ci: Run clang tidy checks for each PR #3258
refactor: make version checking a constexpr operation #3329
refactor: use helper method for model variables #3326
fix:
self.classes_(indices])in sklearn VW #3332refactor: Add label and use builder to set learner features in expreplay, gd_mf, get_pmf, interact #3330
refactor: remove redunant read message from reading interface #3325
refactor: Add label and use builder to set learner features in cs_active and explore_eval #3323
test: fix simulator forward declaration #3322
refactor: clean up search setup a bit #3286
feat: add clamp function to math library and migrate usages #3299
fix: perf issues found by clang-tidy #3319
fix: fix incorrect set of maxk #3298
fix: don't use heap for io_buf #3317
feat: create vw-dump-options program to dump all options into json format #3313
fix: fix multiple definitions caused by non-inline header lambdas in benchmarks #3316
chore: add CMakeUserPresets.json to .gitignore #3315
refactor: explicitly pass buffer into parser read call #3314
refactor: Add label and use builder to set learner features in cbzoo and confidence #3310
test: add cb_sim ref to test callback #3311
ci: move to Ubuntu18.04 for CI jobs #3308
(origin/full_name_namespace_extents) refactor: Add label and use builder to set learner features in cb_to_cb_adf and cbify #3309
refactor: migrate svrg to builder #3284
refactor: Move empty interaction check into inner scope where size is known #3300
chore: bump version of action-semantic-pull-request -> 3.4.2 #3306
fix: remove v_array copy from --onethread and std::function from parse_dispatch #3301
refactor: remove dependence on all for get_best_constant #3307
feat: update active_interactor.py for Python3 #3294
test: add kill cache to test 344 so it can be rerun without failure #3303
ci: test remove update for python env issue #3305
refactor: migrate stagewise_poly to builder #3285
refactor: migrate pmf_to_pdf to builder #3287
chore: remove '.*' from .gitignore #3295
fix: add back setting active property in reduction setup #3290
fix: undo active printing change #3292
fix: Use random state in simulator for cross-platform #3293
test: simulator with per example callback #3291
test: unit tests improvements #3281
feat: extent based namespaces #3208
test: add output on failure for test_with_output #3283
refactor: use override for loss function virtual functions #3280
refactor: use vector instead of raw buffer for reading model files #3279
refactor: refactor test filtering, add typing #3274
ci: turn on new valgrind script in parallel #3277
fix: resolve more gcc warnings #3271
fix: properly release memory in the event of an error #3272
ci: Change valgrind log path #3276
test: (cpp) add cb explore simulator for unit testing #3273
(origin/ataymano/ccb_metrics) refactor!: remove deprecations targeted for VW 9.0 #3268
ci: remove Python3.6 from CI #3275
feat: support skip reasons in run_tests.py #3270
refactor: migrate active to builder and fix warnings #3243
fix: fix warning is search from unsafely using realloc #3255
refactor: Use reference in marginal constructor for non-nullable variable #3269
feat: add save/load to ChiSquared #3267
refactor: Add label and use builder to set learner features in cb_explore #3266
refactor: use new builder for marginal and other fixes #3250
refactor: migrate sender to builder #3260
refactor: Encapsulate resetting and current file in io_buf #3265
fix: incorrect change of push_at in search #3240
refactor: migrate audit_regressor to builder and fix issues #3244
refactor: migrate baseline to builder #3247
refactor: migrate scorer to builder #3261
refactor: Add label and use builder to set learner features in bs, cats, cb_algs #3264
refactor: migrate shared_feature_merger to builder #3262
fix: move lda above scorer to avoid incorrect application of scorer #3263