Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect change of push_at in search #3240

Merged
merged 6 commits into from Aug 30, 2021

Conversation

jackgerrits
Copy link
Member

A while ago I updated the push_at function to use insert. It turns out it was never a push operation but was a set operation.

See the bug introducing commit:
ee65050

@jackgerrits jackgerrits merged commit 311fa10 into VowpalWabbit:master Aug 30, 2021
@jackgerrits jackgerrits deleted the jagerrit/search_fix branch August 30, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants