Marcozo/cmake clean

[eisber]

No description provided.

[JohnLangford]

This pull request introduces 1 alert when merging e5b70fd into 90635fb - view on LGTM.com

new alerts:

• 1 for Nested loops with same variable

---

Comment posted by LGTM.com

[JohnLangford]

This pull request introduces 1 alert when merging 4fac83f into 90635fb - view on LGTM.com

new alerts:

• 1 for Nested loops with same variable

---

Comment posted by LGTM.com

[JohnLangford]

This pull request introduces 1 alert when merging 8acf377 into 543dc5e - view on LGTM.com

new alerts:

• 1 for Nested loops with same variable

---

Comment posted by LGTM.com

[JohnLangford]

This pull request introduces 1 alert and fixes 1 when merging 8e183a2 into 543dc5e - view on LGTM.com

new alerts:

• 1 for Nested loops with same variable

fixed alerts:

• 1 for Expression has no effect

---

Comment posted by LGTM.com

[JohnLangford]

This pull request introduces 1 alert when merging 474ecf8 into 543dc5e - view on LGTM.com

new alerts:

• 1 for Nested loops with same variable

---

Comment posted by LGTM.com

[JohnLangford]

This pull request introduces 1 alert and fixes 1 when merging 95716c5 into 543dc5e - view on LGTM.com

new alerts:

• 1 for Nested loops with same variable

fixed alerts:

• 1 for Expression has no effect

---

Comment posted by LGTM.com

[JohnLangford]

What needs to be done on this for a merge?

[eisber]

The C# wrapper part is missing. Also the rl client library test hangs. I spoke with Rajan, he’ll look into it.

…

-Markus From: John <notifications@github.com> Sent: Wednesday, July 18, 2018 3:15 AM To: JohnLangford/vowpal_wabbit <vowpal_wabbit@noreply.github.com> Cc: Markus Cozowicz <marcozo@microsoft.com>; Author <author@noreply.github.com> Subject: Re: [JohnLangford/vowpal_wabbit] Marcozo/cmake clean (#1526) What needs to be done on this for a merge? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJohnLangford%2Fvowpal_wabbit%2Fpull%2F1526%23issuecomment-405833552&data=02%7C01%7Cmarcozo%40microsoft.com%7C3a61a9e7fe004afa831f08d5ec7e2fe7%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636674949067878981&sdata=C%2F7F0sENxgKurC%2Bd3xgp1JZxxJ5hdHYZlUAtMbr9h5E%3D&reserved=0>, or mute the thread<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJrCTlDGo8-jUDKuHSswi-ZG-Dts5Vqnks5uHuB5gaJpZM4VLorA&data=02%7C01%7Cmarcozo%40microsoft.com%7C3a61a9e7fe004afa831f08d5ec7e2fe7%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636674949067878981&sdata=BT7Rpe9ZUa8AYufaNlKN3yXjGd9eYE62aNTV9VviuTA%3D&reserved=0>.

[JohnLangford]

Closing in favor of #1624