Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug causing to reset dump_interval to 1 when input model -i is provided #1558

Merged
merged 3 commits into from
Aug 17, 2018

Conversation

marco-rossi29
Copy link
Collaborator

@marco-rossi29 marco-rossi29 commented Aug 2, 2018

Order of dump_interval modifications before bug fix:

  1. dump_interval is initialized to 1 (see here)
  2. dump_interval is updated according to -P input (see here)
  3. If -i is present, dump_interval is updated according to dump_interval at time of model saving (see here)
  4. if --preserve_performance_counter is not present (see here), dump_interval is WRONGLY reset to 1 (see here) rather than be reset to value after step 2

@JohnLangford JohnLangford merged commit ec0e817 into VowpalWabbit:master Aug 17, 2018
@marco-rossi29 marco-rossi29 deleted the dump_interval_bug branch August 20, 2018 17:33
marco-rossi29 added a commit to marco-rossi29/vowpal_wabbit that referenced this pull request Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants