Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harden rllib's test_cpp in validation mode #1645

Merged
merged 5 commits into from
Oct 18, 2018
Merged

Harden rllib's test_cpp in validation mode #1645

merged 5 commits into from
Oct 18, 2018

Conversation

lokitoth
Copy link
Member

@lokitoth lokitoth commented Oct 18, 2018 •
edited
Loading

  • Add throttling to verify-mode by allowing sleeping between loop run-throughs.
  • Add background error callback to avoid getting into permanent error mode after the first background error

@lokitoth
Add background error callback
f62d729 
This will enable us to avoid getting into permanent error mode on the
first background error that gets hit.
@lokitoth lokitoth changed the title Add command-line option to sleep between loop iterations in rllib's test_cpp Harden rllib's test_cpp in validation mode Oct 18, 2018
@jackgerrits jackgerrits merged commit 6aecaff into VowpalWabbit:master Oct 18, 2018
@lokitoth lokitoth deleted the test_cpp_sleep branch April 16, 2019 13:47
lokitoth added a commit to lokitoth/vowpal_wabbit that referenced this pull request Dec 20, 2019
@lokitoth @jackgerrits
Harden rllib's test_cpp in validation mode (VowpalWabbit#1645)
00add9f 
* Add command-line option to sleep between loop cycles

* Change interval check to be a range comparison

* Add background error callback

This will enable us to avoid getting into permanent error mode on the
first background error that gets hit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackgerrits jackgerrits jackgerrits approved these changes

@ataymano ataymano ataymano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lokitoth @jackgerrits @ataymano