Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test 175 #1751

Merged
merged 1 commit into from
Feb 8, 2019
Merged

Fix test 175 #1751

merged 1 commit into from
Feb 8, 2019

Conversation

yannstad
Copy link
Collaborator

@yannstad yannstad commented Feb 7, 2019 •
edited

This PR fixes some test issues:

  • Test 175 is not enabled on Windows, because the test parser expects an empty line after the test definition.
  • When enabled, the test is failing, because an empty line is missing after the example (thus failing the multi-line detection).
  • Test 59 does not exist, misleading the reading of Travis logs, where the test id is not the parsed id but a counter starting from 1.

@yannstad yannstad force-pushed the fix-tests branch 3 times, most recently from 43d576f to 8303d21 Compare February 8, 2019 07:00
@yannstad yannstad changed the title Fix tests on windows Fix test 175 Feb 8, 2019
@yannstad yannstad mentioned this pull request Feb 8, 2019
Merged
@rajan-chari
Copy link
Member

Looks good to me.

@yannstad yannstad merged commit ab71236 into VowpalWabbit:master Feb 8, 2019
@yannstad yannstad deleted the fix-tests branch February 8, 2019 14:31
@homezcx homezcx mentioned this pull request Feb 21, 2019
Merged
rajan-chari pushed a commit to VowpalWabbit/reinforcement_learning that referenced this pull request Feb 22, 2019
@homezcx @rajan-chari
Update VowpalWabbit submodule (#46)
268b3bc 
RunTests: use test label number instead of counter (VowpalWabbit/vowpal_wabbit#1753)
Small Json parser cleanup (VowpalWabbit/vowpal_wabbit#1759)
Type erase json parser context for easier deletion ((VowpalWabbit/vowpal_wabbit#1760)
Fix static linking (VowpalWabbit/vowpal_wabbit#1758)
Fix build scripts forcing Debug builds. Add LTO mode and fix VW defau…(VowpalWabbit/vowpal_wabbit#1735)
Do not define BOOST_TEST_DYN_LINK when statically linking (VowpalWabbit/vowpal_wabbit#1750)
Convert TopK reduction to be multiline example based (VowpalWabbit/vowpal_wabbit#1752)
vw java 11 compatibility (VowpalWabbit/vowpal_wabbit#1700)
cbify: --cbify_ldf for multiline (csoaa_ldf) input datasets (VowpalWabbit/vowpal_wabbit#1681)
Merge pull request #1751 from yannstad/fix-tests (VowpalWabbit/vowpal_wabbit#1751)
[tests] Make repeat.py compatible with python 3 (VowpalWabbit/vowpal_wabbit#1747)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yannstad @rajan-chari