Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usage of char instead of unsigned char for namespace index #1791

Merged
merged 3 commits into from
Mar 19, 2019
Merged

Fix usage of char instead of unsigned char for namespace index #1791

merged 3 commits into from
Mar 19, 2019

Conversation

jackgerrits
Copy link
Member

@jackgerrits jackgerrits commented Mar 18, 2019 •
edited

This caused problems when the api was used with namespaces >127

@JohnLangford
Copy link
Member

Looks good. Merge when all tests pass.

@jackgerrits jackgerrits merged commit e0ad15e into VowpalWabbit:master Mar 19, 2019
@jackgerrits jackgerrits deleted the jagerrit/namespace_idx_oddity branch April 5, 2019 16:20
jackgerrits added a commit to jackgerrits/vowpal_wabbit that referenced this pull request May 15, 2019
@jackgerrits
Fix usage of char instead of unsigned char for namespace index (Vowpa…
8ce1e01 
…lWabbit#1791)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jackgerrits @JohnLangford