Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand Boost_LIBRARIES for pkg-config libs #1801

Merged
merged 1 commit into from Mar 22, 2019

Conversation

Projects
None yet
3 participants
@jrmarkle
Copy link
Contributor

commented Mar 21, 2019

With the latest cmake build process the installed file libvw.pc contains all the required boost libraries in a semicolon-separated list. This causes the output of pkg-config --libs libvw on Ubuntu 18.04 to be:

-L/usr/local/lib -lvw -lallreduce -pthread /usr/lib/x86_64-linux-gnu/libboost_program_options.so\;/usr/lib/x86_64-linux-gnu/libboost_system.so\;/usr/lib/x86_64-linux-gnu/libboost_thread.so\;/usr/lib/x86_64-linux-gnu/libboost_unit_test_framework.so\;/usr/lib/x86_64-linux-gnu/libboost_chrono.so\;/usr/lib/x86_64-linux-gnu/libboost_date_time.so\;/usr/lib/x86_64-linux-gnu/libboost_atomic.so\;/usr/lib/x86_64-linux-gnu/libpthread.so -lz

which is not useful for passing to the linker.

This change separates the library paths with spaces so that a command such as g++ $(pkg-config --libs libvw) ... can work.

There might be a better, more idiomatic cmake way to fix this.

@jackgerrits

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

Thanks for this fix @jrmarkle. I'm not aware of a more idiomatic way to do this, so looks good.

@JohnLangford JohnLangford merged commit edfc0ba into VowpalWabbit:master Mar 22, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@JohnLangford

This comment has been minimized.

Copy link
Member

commented Mar 22, 2019

Merged, thanks :-)

jackgerrits added a commit to jackgerrits/vowpal_wabbit that referenced this pull request May 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.