Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gd_mf_weights.cc right namespace #1874

Merged
merged 3 commits into from May 14, 2019

Conversation

Projects
None yet
3 participants
@szipkin
Copy link
Contributor

commented May 13, 2019

Use right indices to write out features for the right namespace, correcting bug found in #1871

szipkin added some commits May 13, 2019

Update gd_mf_weights.cc
Use right indices to write out features for the right namespace, correcting bug found in #1871
Merge pull request #1 from szipkin/szipkin-patch-1
Update gd_mf_weights.cc right namespace
Show resolved Hide resolved library/gd_mf_weights.cc
Update gd_mf_weights.cc
Add back rank to the right quadratic calculation
@ataymano

This comment has been minimized.

Copy link
Member

commented May 14, 2019

Looks good, thank you.

@jackgerrits jackgerrits merged commit 8e00eba into VowpalWabbit:master May 14, 2019

8 checks passed

LGTM analysis: C# No code changes detected
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
LGTM analysis: Java No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 73.036%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.