Update gd_mf_weights.cc right namespace #1874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use right indices to write out features for the right namespace, correcting bug found in VowpalWabbit#1871
Update gd_mf_weights.cc right namespace
jackgerrits
approved these changes
May 13, 2019
ataymano
requested changes
May 13, 2019
Add back rank to the right quadratic calculation
ataymano
approved these changes
May 14, 2019
|
Looks good, thank you. |
peterychang
pushed a commit
to peterychang/vowpal_wabbit
that referenced
this pull request
May 24, 2019
* Update gd_mf_weights.cc Use right indices to write out features for the right namespace, correcting bug found in VowpalWabbit#1871 * Update gd_mf_weights.cc Add back rank to the right quadratic calculation
JohnLangford
pushed a commit
that referenced
this pull request
Jun 3, 2019
* pre-merge and remove shared features before sending examples down the reduction stack * copy-paste error in vcxproj file * fixing bad iterator dereference * Enable Version and Tag override for NuGet pack (#1870) * First attempt at softmax learner for cbadf (#1839) * First attempt at softmax learner for cbadf * some bugfixes and proper handling of shared and non-shared examples * add test for cb_adf softmax * Removing redundant safe_probability definition * Update gd_mf_weights.cc right namespace (#1874) * Update gd_mf_weights.cc Use right indices to write out features for the right namespace, correcting bug found in #1871 * Update gd_mf_weights.cc Add back rank to the right quadratic calculation * Fixed warning message ips -> mtr (#1875) * Fix dsjson parser regression and add smoke-test (#1878) * Fix dsjson parser regression and add smoke-test Note: The test is ignored under the C# Unit Tests, because the test driver is not set up to run the native parser. This is an area we should improve outside of the bugfix. * Suppress test for softmax learner * fixing bugs, finding/fixing wrong tests * fixing finish_example, unit tests * cleaning up CB reductions * copying predictions up and down the stack * removing shared example in place. Disabling finish_example * modify unit tests to match outputs. Add patch file to undo this change later * moving patch file to test directory * Removing unused variables, function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use right indices to write out features for the right namespace, correcting bug found in #1871