Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated projects and old scripts #1992

Merged
merged 3 commits into from Aug 6, 2019
Merged

Remove deprecated projects and old scripts #1992

merged 3 commits into from Aug 6, 2019

Conversation

lokitoth
Copy link
Member

@lokitoth lokitoth commented Aug 5, 2019

  • Removes Azure projects which have not been updated/supported in some time.
  • Removes out-of-date README.Windows file (up-to-date content in Wiki)
  • Removes out of date deploy/publish scripts

@JohnLangford
Copy link
Member

This pull request fixes 6 alerts when merging 7240007 into 36e44bc - view on LGTM.com

fixed alerts:

  • 3 for Rethrowing exception variable
  • 2 for Missing Dispose call on local IDisposable
  • 1 for Use of default ToString()

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.

Comment posted by LGTM.com

@jackgerrits
Copy link
Member

Can you remove the link to the old windows readme in the current readme?

@JohnLangford
Copy link
Member

This pull request fixes 6 alerts when merging 6c1037e into 36e44bc - view on LGTM.com

fixed alerts:

  • 3 for Rethrowing exception variable
  • 2 for Missing Dispose call on local IDisposable
  • 1 for Use of default ToString()

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.

Comment posted by LGTM.com

@lokitoth
Remove deprecated projects and old scripts
0885c6b 
* Removes Azure projects which have not been updated/supported in some time.
* Removes out-of-date README.Windows file (up-to-date content in Wiki)
* Removes out of date deploy/publish scripts
* Also adds missing projects to restore.cmd
@lokitoth
Remove reference to deleted README.Windows.md
c876ac6
@JohnLangford
Copy link
Member

This pull request fixes 6 alerts when merging c876ac6 into 36e44bc - view on LGTM.com

fixed alerts:

  • 3 for Rethrowing exception variable
  • 2 for Missing Dispose call on local IDisposable
  • 1 for Use of default ToString()

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.

Comment posted by LGTM.com

@lokitoth lokitoth added this to In Progress in Bug Triage via automation Aug 5, 2019
@lokitoth lokitoth removed this from In Progress in Bug Triage Aug 5, 2019
@JohnLangford
Copy link
Member

My favorite kind of pull request.

@JohnLangford
Copy link
Member

This pull request fixes 6 alerts when merging b22b599 into d36fcf1 - view on LGTM.com

fixed alerts:

  • 3 for Rethrowing exception variable
  • 2 for Missing Dispose call on local IDisposable
  • 1 for Use of default ToString()

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.

Comment posted by LGTM.com

@lokitoth lokitoth merged commit ec0f79c into VowpalWabbit:master Aug 6, 2019
@lokitoth lokitoth deleted the dev/Cleanup branch August 6, 2019 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackgerrits jackgerrits jackgerrits approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lokitoth @JohnLangford @jackgerrits