Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated projects and old scripts #1992

Merged
merged 3 commits into from Aug 6, 2019

Conversation

@lokitoth
Copy link
Member

commented Aug 5, 2019

  • Removes Azure projects which have not been updated/supported in some time.
  • Removes out-of-date README.Windows file (up-to-date content in Wiki)
  • Removes out of date deploy/publish scripts
@JohnLangford

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

This pull request fixes 6 alerts when merging 7240007 into 36e44bc - view on LGTM.com

fixed alerts:

  • 3 for Rethrowing exception variable
  • 2 for Missing Dispose call on local IDisposable
  • 1 for Use of default ToString()

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.


Comment posted by LGTM.com

@lokitoth lokitoth force-pushed the lokitoth:dev/Cleanup branch from 7240007 to 220e5f5 Aug 5, 2019

@jackgerrits

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

Can you remove the link to the old windows readme in the current readme?

@JohnLangford

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

This pull request fixes 6 alerts when merging 6c1037e into 36e44bc - view on LGTM.com

fixed alerts:

  • 3 for Rethrowing exception variable
  • 2 for Missing Dispose call on local IDisposable
  • 1 for Use of default ToString()

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.


Comment posted by LGTM.com

lokitoth added some commits Aug 5, 2019

Remove deprecated projects and old scripts
* Removes Azure projects which have not been updated/supported in some time.
* Removes out-of-date README.Windows file (up-to-date content in Wiki)
* Removes out of date deploy/publish scripts
* Also adds missing projects to restore.cmd

@lokitoth lokitoth force-pushed the lokitoth:dev/Cleanup branch from 6c1037e to c876ac6 Aug 5, 2019

@JohnLangford

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

This pull request fixes 6 alerts when merging c876ac6 into 36e44bc - view on LGTM.com

fixed alerts:

  • 3 for Rethrowing exception variable
  • 2 for Missing Dispose call on local IDisposable
  • 1 for Use of default ToString()

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.


Comment posted by LGTM.com

@lokitoth lokitoth added this to In Progress in Bug Triage via automation Aug 5, 2019

@lokitoth lokitoth removed this from In Progress in Bug Triage Aug 5, 2019

@JohnLangford

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

My favorite kind of pull request.

@JohnLangford

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

This pull request fixes 6 alerts when merging b22b599 into d36fcf1 - view on LGTM.com

fixed alerts:

  • 3 for Rethrowing exception variable
  • 2 for Missing Dispose call on local IDisposable
  • 1 for Use of default ToString()

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.


Comment posted by LGTM.com

@lokitoth lokitoth merged commit ec0f79c into VowpalWabbit:master Aug 6, 2019

10 of 11 checks passed

MacOS CI Build #20190806.2 failed
Details
LGTM analysis: C# 6 fixed alerts
Details
LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: Java No code changes detected
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
LGTM analysis: Python No code changes detected
Details
Linux CI Build #20190806.2 succeeded
Details
Windows CI Build #20190806.2 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 73.019%
Details

@lokitoth lokitoth deleted the lokitoth:dev/Cleanup branch Aug 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.