Remove -q: option entirely #2378
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…preted (correctly) as -q :
lokitoth
reviewed
Apr 2, 2020
| @@ -661,8 +660,6 @@ void parse_feature_tweaks(options_i& options, vw& all, std::vector<std::string>& | |||
| .help("Don't remove interactions with duplicate combinations of namespaces. For ex. this is a " | |||
| "duplicate: '-q ab -q ba' and a lot more in '-q ::'.")) | |||
| .add(make_option("quadratic", quadratics).short_name("q").keep().help("Create and use quadratic features")) | |||
| // TODO this option is unused - remove? | |||
| .add(make_option("q:", q_colon).help("DEPRECATED ':' corresponds to a wildcard for all printable characters")) | |||
There was a problem hiding this comment.
Have we had a major release with this deprecated? If no, I would prefer it if we did not remove it outright, yet.
There was a problem hiding this comment.
There is no way to actually call it, since -q: gets interpreted as -q :. If you can find a way to hit this code then I will hold off on removing it
There was a problem hiding this comment.
Nevermind, it is possible to access it. Will close this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be safely removed as passing
-q:will always be correctly interpreted as the standard-q :command. There, since it is inaccessible and deprecated we should remove it.