Move deletion logic to destructor of vw #2399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalo
approved these changes
Apr 10, 2020
vowpalwabbit/global_data.cc
Outdated
| } | ||
| for (size_t i = 0; i < final_prediction_sink.size(); i++) | ||
| if (final_prediction_sink[i] != 1) |
There was a problem hiding this comment.
nit: What's our bracket style, feel like this is unnecessary might as well change it up in this pr? also for each loop?
There was a problem hiding this comment.
Kind of depends who you ask. I prefer brackets always though personally. Good point, can definitely be a for each.
| IGNORE_DEPRECATED_USAGE_END | ||
|
|
||
| vw::~vw() |
There was a problem hiding this comment.
did you give this a pass to check if we are missing something that got added to the class but not to the old parse args destructor logic? feel that causes room for mismatch
There was a problem hiding this comment.
Yeah I did a pass and deprecated an unused variable. searchstr seems fishy to me but don't want to deal with it in this PR
lalo
approved these changes
Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.