Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change fetching of positional args to be in the options interface #2418

Merged
merged 9 commits into from
May 7, 2020
Merged

Change fetching of positional args to be in the options interface #2418

merged 9 commits into from
May 7, 2020

Conversation

jackgerrits
Copy link
Member

  • Removes a dynamic cast in parse_args
  • Makes it possible for other options providers to give positional args too
  • Makes positional args more generic

peterychang
peterychang approved these changes May 5, 2020
View reviewed changes
Copy link
Collaborator

@peterychang peterychang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not particularly familiar with the options code, but I dont see anything obviously wrong with this

@jackgerrits jackgerrits merged commit 51d31e1 into VowpalWabbit:master May 7, 2020
@lokitoth lokitoth mentioned this pull request May 22, 2020
Merged
@jackgerrits jackgerrits mentioned this pull request Jun 1, 2020
Closed
@jackgerrits jackgerrits deleted the jagerrit/positional branch July 28, 2020 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterychang peterychang peterychang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackgerrits @peterychang