-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: use correct platform suffix for Python native shared library #3678
build: use correct platform suffix for Python native shared library #3678
Conversation
@ngam is it possible to verify this works before the patch release? |
You mean before merging into master or by simply testing this exact PR? I can do both. I want to start a dev branch in the conda-forge vw feedstock for this sort of thing. I will get to it tonight --- that way we can test stuff down there without having to disrupt the stable flow and the outputs would go to a dev channel and so end users won't find it unless they go looking for it. It's a good strategy to test things |
I just meant if it is possible to know if this unblocks the PyPy issue without needing to wait until a release tag is created and pushed Dev channel sounds good! |
Okay, I will do it soon :) |
Thanks so much. Appreciate all of the help so much by the way! |
can confirm! |
…3678) * build: use sysconfig.get_config_vars("EXT_SUFFIX") for python lib extension * single var * debug message * dont overwrite sufix * try dont override get_ext_filename * just use pyd on windows * print get_ext_filename * Fix call * Workaround windows 3.6 and 3.7 * remove testing code
No description provided.