Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VsVim for Mac: Escape remapping not working as expected #2807

Closed
2 tasks
oskarskog opened this issue Mar 26, 2020 · 4 comments · Fixed by #2830 or #2884
Closed
2 tasks

VsVim for Mac: Escape remapping not working as expected #2807

oskarskog opened this issue Mar 26, 2020 · 4 comments · Fixed by #2830 or #2884
Assignees
@nosami
Labels
vs4mac integration

Comments

@oskarskog
Copy link

First of all, thanks for this great plugin!

Describe the bug
I have escape remapped to 'fd' for insert mode in my  ~/.vsvimrc

inoremap fd <esc>

then, when I'm in insert mode and type 'f' no character is inserted, if I press 'f' again one 'f' character appears. If I continue to type some characters and then hit 'd' I'm thrown to normal mode.

To Reproduce
Steps to reproduce the behavior:

  1. remap escape to 'fd' in .vsvimrc
  2. enter insert mode
  3. press 'f' -> no 'f' appears
  4. continue to type
  5. hit 'd' -> you're thrown to normal mode

Expected behavior

With the same mapping in vim the 'f' character normally appears the first time I hit 'f', if not followed by 'd'. Only if I enter 'f' and 'd' right after each other am I thrown back to normal mode.

Environment (please complete the following information):

  • Visual Studio version: Visual Studio for Mac 8.5 (build 3183)
  • VsVim version: 2.8.0.5
  • Programming Language: C#
  • Check(Type 'x') any that are installed:
    • ReSharper
    • Visual Assist

Additional context
Add any other context about the problem here.

Note:
The following is written about contributing.
https://github.com/VsVim/VsVim/blob/master/CONTRIBUTING.md

General Keyboard configuration problems are described below.
#2527
@nosami nosami self-assigned this Mar 26, 2020
@nosami
Copy link
Collaborator

nosami commented Mar 26, 2020

Can confirm. Will try and fix - thanks for reporting!

nosami added a commit to nosami/VsVim that referenced this issue May 22, 2020
@nosami
(Mac) Change TryProcess(keyInput) to use VimBuffer.CanProcess
4d80311 
I think the previous use of CanProcessAsCommand was to workaround the fact
that I couldn't previously prevent keys from being handled in VSMac 8.3.

This (hack) meant that VSVim wasn't handling many Insert mode keypresses which
meant that Insert mode key remaps and Insert mode macro recordings weren't
working.

Fixes VsVim#2807
Fixes VsVim#2820
@nosami nosami mentioned this issue May 22, 2020
Merged
@nosami
Copy link
Collaborator

nosami commented May 26, 2020

Fixed in 2.8.0.8

@nosami nosami reopened this Aug 7, 2020
@nosami
Copy link
Collaborator

nosami commented Aug 7, 2020

Reopened as 2.8.0.8 was pulled from the feed.

@nosami nosami mentioned this issue Apr 22, 2021
Merged
@nosami nosami closed this as completed in ec63165 Apr 24, 2021
@nosami
Copy link
Collaborator

nosami commented Apr 24, 2021

Fixed in 2.8.0.11 . You can get it from the Releases page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nosami nosami

Labels
vs4mac integration
Projects
None yet
Milestone
No milestone
2 participants
@nosami @oskarskog