Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VSVim for Mac: Insert mode keys aren't being recorded by macros #2820

Closed
nosami opened this issue Apr 18, 2020 · 1 comment · Fixed by #2830
Closed

VSVim for Mac: Insert mode keys aren't being recorded by macros #2820

nosami opened this issue Apr 18, 2020 · 1 comment · Fixed by #2830
Assignees
@nosami
Labels
vs4mac integration

Comments

@nosami
Copy link
Collaborator

nosami commented Apr 18, 2020

Describe the bug
Insert mode keys aren't being recorded by macros.

To Reproduce
Steps to reproduce the behavior:

  1. Record a macro containing a mixture of normal mode and insert mode keys
  2. Replay the macro
  3. Observe that only the normal mode keys are replayed

Expected behavior
Both normal and insert mode keys should get replayed.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

  • Visual Studio version: Mac
  • VsVim version: 2.8.0.6
@nosami nosami self-assigned this Apr 18, 2020
nosami added a commit to nosami/VsVim that referenced this issue May 22, 2020
@nosami
(Mac) Change TryProcess(keyInput) to use VimBuffer.CanProcess
4d80311 
I think the previous use of CanProcessAsCommand was to workaround the fact
that I couldn't previously prevent keys from being handled in VSMac 8.3.

This (hack) meant that VSVim wasn't handling many Insert mode keypresses which
meant that Insert mode key remaps and Insert mode macro recordings weren't
working.

Fixes VsVim#2807
Fixes VsVim#2820
@nosami nosami mentioned this issue May 22, 2020
Merged
@nosami
Copy link
Collaborator Author

nosami commented May 26, 2020

Fixed in 2.8.0.8

@nosami nosami mentioned this issue Aug 7, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nosami nosami

Labels
vs4mac integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(Mac) Change TryProcess(keyInput) to use VimBuffer.CanProcess nosami/VsVim
1 participant
@nosami