Skip to content
This repository has been archived by the owner on May 31, 2024. It is now read-only.

Cleanup 1.8.1 #1790

Merged
merged 4 commits into from
Dec 27, 2017
Merged

Cleanup 1.8.1 #1790

merged 4 commits into from
Dec 27, 2017

Conversation

luhagel
Copy link
Contributor

@luhagel luhagel commented Dec 27, 2017

Couple of minor things I found while upgrading if I find more, I'll append them here.

  • vs code typings aren't being ignored in the .gitignore, now that Vulcan ships with a .vscode folder, those shouldn't be tracked
  • the data table EditButton had two extensions
  • small typo in the prestart script
  • since it's not placed in a .whatever directory, meteor loads the prestart script which causes all sorts of fuzz, created a .vulcan directory and moved it there

@SachaG
Copy link
Contributor

SachaG commented Dec 27, 2017

Nice! Actually I'm not sure if we should even keep that prestart script. Probably best to fold it in the Vulcan CLI (https://github.com/VulcanJS/vulcanjs-cli)

@SachaG SachaG merged commit 45fb2f2 into VulcanJS:master Dec 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants